diff --git a/typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php b/typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php index af80fc71d0..9c230074b9 100644 --- a/typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php +++ b/typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php @@ -278,7 +278,8 @@ class Typo3DatabaseBackend extends AbstractBackend implements TaggableBackendInt // A large set of tags was detected. Process it in chunks to guard against exceeding // maximum SQL query limits. if (count($tags) > 100) { - array_walk(array_chunk($tags, 100), [$this, 'flushByTags']); + $array_chunk = array_chunk($tags, 100); + array_walk($array_chunk, [$this, 'flushByTags']); return; } // VERY simple quoting of tags is sufficient here for performance. Tags are already diff --git a/typo3/sysext/core/Classes/Core/Environment.php b/typo3/sysext/core/Classes/Core/Environment.php index 8ce8c9eb3f..bb75563d24 100644 --- a/typo3/sysext/core/Classes/Core/Environment.php +++ b/typo3/sysext/core/Classes/Core/Environment.php @@ -236,7 +236,6 @@ class Environment * Helper methods to easily find occurrences, however as these properties are not computed * it is very possible that these methods will become obsolete in the near future. */ - /** * Previously found under typo3conf/l10n/ * Please note that this might be gone at some point diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php index e163072b12..b6d30bb09e 100644 --- a/typo3/sysext/core/Classes/DataHandling/DataHandler.php +++ b/typo3/sysext/core/Classes/DataHandling/DataHandler.php @@ -7872,7 +7872,6 @@ class DataHandler implements LoggerAwareInterface * Clearing cache * ******************************/ - /** * Clearing the cache based on a page being updated * If the $table is 'pages' then cache is cleared for all pages on the same level (and subsequent?) diff --git a/typo3/sysext/core/Classes/Database/ReferenceIndex.php b/typo3/sysext/core/Classes/Database/ReferenceIndex.php index b42b3206fd..7b0cb81436 100644 --- a/typo3/sysext/core/Classes/Database/ReferenceIndex.php +++ b/typo3/sysext/core/Classes/Database/ReferenceIndex.php @@ -601,7 +601,6 @@ class ReferenceIndex implements LoggerAwareInterface * Get relations from table row * *******************************/ - /** * Returns relation information for a $table/$row-array * Traverses all fields in input row which are configured in TCA/columns @@ -777,7 +776,6 @@ class ReferenceIndex implements LoggerAwareInterface * Setting values * *******************************/ - /** * Setting the value of a reference or removing it completely. * Usage: For lowlevel clean up operations! diff --git a/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php b/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php index fccfc54e2f..cf7bcfccd9 100644 --- a/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php +++ b/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php @@ -420,7 +420,6 @@ class SoftReferenceIndex implements SingletonInterface * Helper functions * *************************/ - /** * Analyze content as a TypoLink value and return an array with properties. * TypoLinks format is: . diff --git a/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php b/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php index 2347e70079..69f84eb0ab 100644 --- a/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php +++ b/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php @@ -197,7 +197,6 @@ class PageRepository implements LoggerAwareInterface * Selecting page records * **************************/ - /** * Loads the full page record for the given page ID. * @@ -657,7 +656,6 @@ class PageRepository implements LoggerAwareInterface * Page related: Menu, Domain record, Root line * ************************************************/ - /** * Returns an array with page rows for subpages of a certain page ID. This is used for menus in the frontend. * If there are mount points in overlay mode the _MP_PARAM field is set to the correct MPvar. @@ -1157,7 +1155,6 @@ class PageRepository implements LoggerAwareInterface * Selecting records in general * ********************************/ - /** * Checks if a record exists and is accessible. * The row is returned if everything's OK. @@ -1246,7 +1243,6 @@ class PageRepository implements LoggerAwareInterface * Standard clauses * ********************************/ - /** * Returns a part of a WHERE clause which will filter out records with start/end * times or hidden/fe_groups fields set to values that should de-select them @@ -1400,7 +1396,6 @@ class PageRepository implements LoggerAwareInterface * Versioning Preview * **********************/ - /** * Finding online PID for offline version record * diff --git a/typo3/sysext/core/Classes/Html/RteHtmlParser.php b/typo3/sysext/core/Classes/Html/RteHtmlParser.php index 63fdf77f59..76a8209efd 100644 --- a/typo3/sysext/core/Classes/Html/RteHtmlParser.php +++ b/typo3/sysext/core/Classes/Html/RteHtmlParser.php @@ -351,7 +351,6 @@ class RteHtmlParser extends HtmlParser implements LoggerAwareInterface * Specific RTE TRANSFORMATION functions * *************************************/ - /** * Transformation handler: 'ts_links' / direction: "db" * Processing anchor tags, and resolves them correctly again via the LinkService syntax @@ -523,7 +522,6 @@ class RteHtmlParser extends HtmlParser implements LoggerAwareInterface * Generic RTE transformation, analysis and helper functions * **************************************************************/ - /** * Function for cleaning content going into the database. * Content is cleaned eg. by removing unallowed HTML and ds-HSC content diff --git a/typo3/sysext/core/Classes/Resource/AbstractFile.php b/typo3/sysext/core/Classes/Resource/AbstractFile.php index e4d8a65c84..206f72d38a 100644 --- a/typo3/sysext/core/Classes/Resource/AbstractFile.php +++ b/typo3/sysext/core/Classes/Resource/AbstractFile.php @@ -192,7 +192,8 @@ abstract class AbstractFile implements FileInterface throw new \RuntimeException('File has been deleted.', 1329821480); } if (empty($this->properties['size'])) { - $size = array_pop($this->getStorage()->getFileInfoByIdentifier($this->getIdentifier(), ['size'])); + $getFileInfoByIdentifier = $this->getStorage()->getFileInfoByIdentifier($this->getIdentifier(), ['size']); + $size = array_pop($getFileInfoByIdentifier); } else { $size = $this->properties['size']; } @@ -272,7 +273,8 @@ abstract class AbstractFile implements FileInterface */ public function getMimeType() { - return $this->properties['mime_type'] ?: array_pop($this->getStorage()->getFileInfoByIdentifier($this->getIdentifier(), ['mimetype'])); + $getFileInfoByIdentifier = $this->getStorage()->getFileInfoByIdentifier($this->getIdentifier(), ['mimetype']); + return $this->properties['mime_type'] ?: array_pop($getFileInfoByIdentifier); } /** diff --git a/typo3/sysext/core/Classes/Resource/ResourceStorage.php b/typo3/sysext/core/Classes/Resource/ResourceStorage.php index b5f3164712..ac8b728040 100644 --- a/typo3/sysext/core/Classes/Resource/ResourceStorage.php +++ b/typo3/sysext/core/Classes/Resource/ResourceStorage.php @@ -1787,11 +1787,12 @@ class ResourceStorage implements ResourceStorageInterface $contentDisposition = $asDownload ? 'attachment' : 'inline'; $stream = new FalDumpFileContentsDecoratorStream($file->getIdentifier(), $this->driver, $file->getSize()); + $getFileInfoByIdentifier = $this->driver->getFileInfoByIdentifier($file->getIdentifier(), ['mtime']); $headers = [ 'Content-Disposition' => $contentDisposition . '; filename="' . $downloadName . '"', 'Content-Type' => $overrideMimeType ?: $file->getMimeType(), 'Content-Length' => (string)$file->getSize(), - 'Last-Modified' => gmdate('D, d M Y H:i:s', array_pop($this->driver->getFileInfoByIdentifier($file->getIdentifier(), ['mtime']))) . ' GMT', + 'Last-Modified' => gmdate('D, d M Y H:i:s', array_pop($getFileInfoByIdentifier)) . ' GMT', // Cache-Control header is needed here to solve an issue with browser IE8 and lower // See for more information: http://support.microsoft.com/kb/323308 'Cache-Control' => '', diff --git a/typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php b/typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php index 1f70a097dc..9ca6e123e4 100644 --- a/typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php +++ b/typo3/sysext/core/Classes/Utility/File/BasicFileUtility.php @@ -144,7 +144,6 @@ class BasicFileUtility * Cleaning functions * *********************/ - /** * Returns a string where any character not matching [.a-zA-Z0-9_-] is substituted by '_' * Trailing dots are removed diff --git a/typo3/sysext/core/Classes/Utility/GeneralUtility.php b/typo3/sysext/core/Classes/Utility/GeneralUtility.php index e7a8a376d7..b4df750518 100644 --- a/typo3/sysext/core/Classes/Utility/GeneralUtility.php +++ b/typo3/sysext/core/Classes/Utility/GeneralUtility.php @@ -974,7 +974,6 @@ class GeneralUtility * ARRAY FUNCTIONS * *************************/ - /** * Explodes a $string delimited by $delimiter and casts each item in the array to (int). * Corresponds to \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(), but with conversion to integers for all values. @@ -2489,7 +2488,6 @@ class GeneralUtility * SYSTEM INFORMATION * *************************/ - /** * Returns the link-url to the current script. * In $getParams you can set associative keys corresponding to the GET-vars you wish to add to the URL. If you set them empty, they will remove existing GET-vars from the current URL.